Skip to content

Improve toString() #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Improve toString() #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fc08e8
Prepend class name to toString() result
swallez Jun 21, 2022
0100ca8
Implement toString() in union types
swallez Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions java-client/src/main/java/co/elastic/clients/elasticsearch/_types/GeoBounds.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.json.UnionDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
Expand Down Expand Up @@ -167,6 +168,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends ObjectBuilderBase implements ObjectBuilder<GeoBounds> {
private Kind _kind;
private Object _value;
Expand Down
6 changes: 6 additions & 0 deletions java-client/src/main/java/co/elastic/clients/elasticsearch/_types/GeoHashPrecision.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.json.UnionDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
Expand Down Expand Up @@ -153,6 +154,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends ObjectBuilderBase implements ObjectBuilder<GeoHashPrecision> {
private Kind _kind;
private Object _value;
Expand Down
6 changes: 6 additions & 0 deletions java-client/src/main/java/co/elastic/clients/elasticsearch/_types/GeoLocation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.json.UnionDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
Expand Down Expand Up @@ -188,6 +189,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends ObjectBuilderBase implements ObjectBuilder<GeoLocation> {
private Kind _kind;
private Object _value;
Expand Down
2 changes: 1 addition & 1 deletion java-client/src/main/java/co/elastic/clients/elasticsearch/_types/RequestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public RequestBase() {
@Override
public String toString() {

StringBuilder sb = new StringBuilder();
StringBuilder sb = new StringBuilder(this.getClass().getSimpleName()).append(": ");

try {
@SuppressWarnings("unchecked")
Expand Down
6 changes: 6 additions & 0 deletions java-client/src/main/java/co/elastic/clients/elasticsearch/_types/Script.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.json.UnionDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
Expand Down Expand Up @@ -125,6 +126,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends ObjectBuilderBase implements ObjectBuilder<Script> {
private Kind _kind;
private Object _value;
Expand Down
6 changes: 6 additions & 0 deletions java-client/src/main/java/co/elastic/clients/elasticsearch/_types/Slices.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.json.UnionDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
Expand Down Expand Up @@ -146,6 +147,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends ObjectBuilderBase implements ObjectBuilder<Slices> {
private Kind _kind;
private Object _value;
Expand Down
5 changes: 5 additions & 0 deletions java-client/src/main/java/co/elastic/clients/elasticsearch/_types/SortOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {
}
}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends WithJsonObjectBuilderBase<Builder> implements ObjectBuilder<SortOptions> {
private Kind _kind;
private Object _value;
Expand Down
6 changes: 6 additions & 0 deletions java-client/src/main/java/co/elastic/clients/elasticsearch/_types/Time.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.json.UnionDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
Expand Down Expand Up @@ -155,6 +156,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends ObjectBuilderBase implements ObjectBuilder<Time> {
private Kind _kind;
private Object _value;
Expand Down
6 changes: 6 additions & 0 deletions java-client/src/main/java/co/elastic/clients/elasticsearch/_types/Transform.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectBuilderDeserializer;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
Expand Down Expand Up @@ -192,6 +193,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends WithJsonObjectBuilderBase<Builder> implements ObjectBuilder<Transform> {
private Kind _kind;
private Object _value;
Expand Down
6 changes: 6 additions & 0 deletions java-client/src/main/java/co/elastic/clients/elasticsearch/_types/WaitForActiveShards.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.json.UnionDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
Expand Down Expand Up @@ -146,6 +147,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends ObjectBuilderBase implements ObjectBuilder<WaitForActiveShards> {
private Kind _kind;
private Object _value;
Expand Down
6 changes: 6 additions & 0 deletions ...-client/src/main/java/co/elastic/clients/elasticsearch/_types/aggregations/Aggregate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
import co.elastic.clients.util.ObjectBuilder;
Expand Down Expand Up @@ -1385,6 +1386,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends ObjectBuilderBase implements ObjectBuilder<Aggregate> {
private Kind _kind;
private AggregateVariant _value;
Expand Down
6 changes: 6 additions & 0 deletions ...lient/src/main/java/co/elastic/clients/elasticsearch/_types/aggregations/Aggregation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectBuilderDeserializer;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
Expand Down Expand Up @@ -1581,6 +1582,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends WithJsonObjectBuilderBase<Builder> {
private Kind _kind;
private Object _value;
Expand Down
5 changes: 5 additions & 0 deletions java-client/src/main/java/co/elastic/clients/elasticsearch/_types/aggregations/Buckets.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder<TBucket> extends ObjectBuilderBase implements ObjectBuilder<Buckets<TBucket>> {
private Kind _kind;
private Object _value;
Expand Down
6 changes: 6 additions & 0 deletions ...lient/src/main/java/co/elastic/clients/elasticsearch/_types/aggregations/BucketsPath.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.json.UnionDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
Expand Down Expand Up @@ -176,6 +177,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends ObjectBuilderBase implements ObjectBuilder<BucketsPath> {
private Kind _kind;
private Object _value;
Expand Down
6 changes: 6 additions & 0 deletions ...ain/java/co/elastic/clients/elasticsearch/_types/aggregations/CategorizeTextAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.json.UnionDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
Expand Down Expand Up @@ -135,6 +136,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends ObjectBuilderBase implements ObjectBuilder<CategorizeTextAnalyzer> {
private Kind _kind;
private Object _value;
Expand Down
6 changes: 6 additions & 0 deletions ...ent/src/main/java/co/elastic/clients/elasticsearch/_types/aggregations/FieldDateMath.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.json.UnionDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
Expand Down Expand Up @@ -154,6 +155,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends ObjectBuilderBase implements ObjectBuilder<FieldDateMath> {
private Kind _kind;
private Object _value;
Expand Down
6 changes: 6 additions & 0 deletions ...t/src/main/java/co/elastic/clients/elasticsearch/_types/aggregations/InferenceConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectBuilderDeserializer;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
Expand Down Expand Up @@ -164,6 +165,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends WithJsonObjectBuilderBase<Builder> implements ObjectBuilder<InferenceConfig> {
private Kind _kind;
private Object _value;
Expand Down
6 changes: 6 additions & 0 deletions ...n/java/co/elastic/clients/elasticsearch/_types/aggregations/MovingAverageAggregation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectBuilderDeserializer;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
Expand Down Expand Up @@ -213,6 +214,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends WithJsonObjectBuilderBase<Builder>
implements
ObjectBuilder<MovingAverageAggregation> {
Expand Down
6 changes: 6 additions & 0 deletions ...lient/src/main/java/co/elastic/clients/elasticsearch/_types/aggregations/Percentiles.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.json.UnionDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
Expand Down Expand Up @@ -152,6 +153,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends ObjectBuilderBase implements ObjectBuilder<Percentiles> {
private Kind _kind;
private Object _value;
Expand Down
6 changes: 6 additions & 0 deletions ...ient/src/main/java/co/elastic/clients/elasticsearch/_types/aggregations/TermsExclude.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.json.UnionDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
Expand Down Expand Up @@ -158,6 +159,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends ObjectBuilderBase implements ObjectBuilder<TermsExclude> {
private Kind _kind;
private Object _value;
Expand Down
6 changes: 6 additions & 0 deletions ...ient/src/main/java/co/elastic/clients/elasticsearch/_types/aggregations/TermsInclude.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import co.elastic.clients.json.JsonpDeserializer;
import co.elastic.clients.json.JsonpMapper;
import co.elastic.clients.json.JsonpSerializable;
import co.elastic.clients.json.JsonpUtils;
import co.elastic.clients.json.ObjectDeserializer;
import co.elastic.clients.json.UnionDeserializer;
import co.elastic.clients.util.ApiTypeHelper;
Expand Down Expand Up @@ -162,6 +163,11 @@ public void serialize(JsonGenerator generator, JsonpMapper mapper) {

}

@Override
public String toString() {
return JsonpUtils.toString(this);
}

public static class Builder extends ObjectBuilderBase implements ObjectBuilder<TermsInclude> {
private Kind _kind;
private Object _value;
Expand Down
Loading