Skip to content

Ability to clear/reset mocks #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 22, 2020
Merged

Ability to clear/reset mocks #13

merged 3 commits into from
Jul 22, 2020

Conversation

@Jacse
Copy link
Contributor

@Jacse Jacse commented Jul 19, 2020

Closes #12

@cla-checker-service
Copy link

cla-checker-service bot commented Jul 19, 2020 •
edited
Loading

💚 CLA has been signed

delvedor
delvedor reviewed Jul 22, 2020
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Can you also return this at the end of each method?
So we can keep the API chainable :)

delvedor
delvedor approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit 40317b7 into elastic:master Jul 22, 2020
@Jacse Jacse deleted the clear-mocks branch July 22, 2020 07:58
@delvedor
Copy link
Member

delvedor commented Jul 22, 2020

Landed in v0.3.0, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delvedor delvedor delvedor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clear mocks

2 participants

@Jacse @delvedor