-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secure json parsing #1110
Secure json parsing #1110
Conversation
* Safe json parsing * Updated test
* Safe json parsing * Updated test
* Safe json parsing * Updated test
This breaks perfectly valid existing code: Consider the request:
The response is:
This will now throw a DeserializtionError on a perfectly valid response. It also occurs in many other contexts which depend on the data (such as |
Hi @matAtWork, please see #1408 (comment). |
Warning to other users: this PR introduces a breaking change that is dependent on the data in your ES index. More details are in the above issue |
This pull request adds a protection mechanism against malicious JSON documents, avoiding prototype pollution attacks.
Further reading: Square Brackets are the Enemy