Skip to content

Support mapbox content type #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 2, 2021
Merged

Support mapbox content type #1500

merged 5 commits into from
Aug 2, 2021

Conversation

delvedor
Copy link
Member

@delvedor delvedor commented Jul 22, 2021 •
edited
Loading

As titled.
If this specific content type is detected, the body will be returned as a buffer.

TODO:

  • docs

@delvedor delvedor requested a review from thomasneirynck July 22, 2021 13:32
thomasneirynck
thomasneirynck approved these changes Jul 22, 2021
View reviewed changes
Copy link

@thomasneirynck thomasneirynck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with a full round-trip, using this client in Kibana and reading real mvt-responses from Elasticsearch, displaying them in Maps. Works great!

@delvedor delvedor marked this pull request as ready for review July 23, 2021 15:23
@delvedor delvedor mentioned this pull request Jul 23, 2021
Merged
@delvedor delvedor merged commit b0a7a21 into master Aug 2, 2021
@delvedor delvedor deleted the support-mapbox-content-type branch August 2, 2021 09:19
github-actions bot pushed a commit that referenced this pull request Aug 2, 2021
@delvedor @github-actions
Support mapbox content type (#1500)
8e0edc3
@github-actions github-actions bot mentioned this pull request Aug 2, 2021
Merged
@thomasneirynck thomasneirynck mentioned this pull request Aug 9, 2021
Closed
@delvedor delvedor mentioned this pull request Aug 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
backport 7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delvedor @thomasneirynck