Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hang in bulk helper semaphore when server responses are slower than flushInterval #2027

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Fix hang in bulk helper semaphore when server responses are slower than flushInterval #2027

merged 5 commits into from
Feb 6, 2024

Commits on Oct 3, 2023

  1. Set version to 8.10.1

    @JoshMock
    JoshMock committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    a50385d View commit details
    Browse the repository at this point in the history

  2. Add tests for bulk helper with various flush and server timeouts

    @JoshMock
    JoshMock committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    291b3af View commit details
    Browse the repository at this point in the history

  3. Copy and empty bulkBody when flushBytes is reached 

    Before it was waiting until after semaphore resolved, then sending with
a reference to bulkBody. If flushInterval is reached after `await
semaphore()` but before `send(bulkBody)`, onFlushTimeout is "stealing"
bulkBody so that there is nothing left in bulkBody for the flushBytes
block to send, causing an indefinite hang for a promise that does not
resolve.
    @JoshMock
    JoshMock committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    ddcfac9 View commit details
    Browse the repository at this point in the history

  4. comment typo fixes

    @JoshMock
    JoshMock committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    bcdca23 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Merge branch 'main' into semaphore-hang

    @pquentin
    pquentin authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    bd72631 View commit details
    Browse the repository at this point in the history