Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure new connections inherit client's set defaults #2159

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

JoshMock
Copy link
Member

When creating connections for each node, if the node was provided as a string rather than an object, it would not inherit its client's default connection options.

Fixes #1791.

@JoshMock JoshMock merged commit 05e3139 into main Mar 20, 2024
10 checks passed
@JoshMock JoshMock deleted the fix-options-node-overwrite branch March 20, 2024 21:32
github-actions bot pushed a commit that referenced this pull request Mar 20, 2024
* Add test confirming the issue

See #1791

* fix: ensure new connections inherit the client instance's defaults

for #1791

(cherry picked from commit 05e3139)
github-actions bot pushed a commit that referenced this pull request Mar 20, 2024
* Add test confirming the issue

See #1791

* fix: ensure new connections inherit the client instance's defaults

for #1791

(cherry picked from commit 05e3139)
@JoshMock JoshMock added the apply-to-serverless Used by automation to generate a patch from a PR and apply it to elasticsearch-serverless-js label Mar 27, 2024
JoshMock added a commit to elastic/elasticsearch-serverless-js that referenced this pull request Mar 27, 2024
JoshMock added a commit to elastic/elasticsearch-serverless-js that referenced this pull request Mar 27, 2024
* Apply patch from elastic/elasticsearch-js#2159

* Ensure new connections inherit client's set defaults

---------

Co-authored-by: JoshMock <160161+JoshMock@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apply-to-serverless Used by automation to generate a patch from a PR and apply it to elasticsearch-serverless-js backport 8.12 backport 8.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request time out after 30 seconds
1 participant