-
Notifications
You must be signed in to change notification settings - Fork 726
Bug #2694 #2731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug #2694 #2731
Conversation
💚 CLA has been signed |
Thanks for this change @Siddhu545! If you can just sign the CLA noted above I'll merge this and ensure it gets out in the next release. |
Thanks! I’ve already signed the CLA, let me know if anything else is needed. |
src/client.ts
Outdated
@@ -35,7 +35,7 @@ import { RedactionOptions } from '@elastic/transport/lib/Transport' | |||
import BaseConnection, { prepareHeaders, ConnectionOptions } from '@elastic/transport/lib/connection/BaseConnection' | |||
import SniffingTransport from './sniffingTransport' | |||
import Helpers from './helpers' | |||
import API from './api' | |||
import API from '../src/api/index' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be changed, and is the reason some tests are failing.
import API from '../src/api/index' | |
import API from './api' |
@Siddhu545 Our CLA checker bases it off of the email address in your commits. It looks like your commits use your email address with an uppercase |
Hi @JoshMock, |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-2731-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9d719ce874af1c471692f3ad45989d91eefd6562
# Push it to GitHub
git push --set-upstream origin backport-2731-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-2731-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9d719ce874af1c471692f3ad45989d91eefd6562
# Push it to GitHub
git push --set-upstream origin backport-2731-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18 Then, create a pull request where the |
Added proper validation and logging for the Elasticsearch Cloud ID during client setup to ensure connectivity and easier debugging. This helps catch misconfigurations early and improves reliability.