Skip to content

Deep merge options on client instantiation #2890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

Conversation

JoshMock
Copy link
Member

@JoshMock JoshMock commented Jul 2, 2025

Fixes #2876
Fixes #2862

@prodsecmachine
Copy link

prodsecmachine commented Jul 2, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@JoshMock JoshMock merged commit 1e6cf8b into main Jul 7, 2025
23 checks passed
@JoshMock JoshMock deleted the deep-merge-opts branch July 7, 2025 16:31
Copy link
Contributor

github-actions bot commented Jul 7, 2025

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-2890-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1e6cf8b58eda7ac804dfd2e5498dcb7a2a5c5a22
# Push it to GitHub
git push --set-upstream origin backport-2890-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-2890-to-8.19.

github-actions bot pushed a commit that referenced this pull request Jul 7, 2025
JoshMock added a commit that referenced this pull request Jul 7, 2025
Co-authored-by: Josh Mock <joshua.mock@elastic.co>
JoshMock added a commit that referenced this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom headers erases all header defaults rather than merging the two
2 participants