Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update docs for 'synced flush' and 'SLM' APIs #972

Merged
merged 1 commit into from
Sep 26, 2019
Merged

[DOCS] Update docs for 'synced flush' and 'SLM' APIs #972

merged 1 commit into from
Sep 26, 2019

Conversation

jrodewig
Copy link
Contributor

Regenerates docs to include the following changes from Elasticsearch documentation:

Plan to backport to 7.x.

@jrodewig
Copy link
Contributor Author

jrodewig commented Sep 20, 2019

Blocks elastic/elasticsearch#46875

@jrodewig
Copy link
Contributor Author

@delvedor You mind taking a look at this when convenient?

It's currently blocking elastic/elasticsearch#46875.

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, sorry for the delay! I can merge this pr, but you are changing code that I'm generating from the rest-api-spec.
The best way to fix this is to update the spec and then regenerate the client code.

@jrodewig
Copy link
Contributor Author

Hi @delvedor . The changes in this PR were created by running node scripts/generate as outlined in:
https://github.com/elastic/elasticsearch-js/blob/master/CONTRIBUTING.md#code-generation

Here are the updates to the original spec:

Let me know if I missed something.

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants