Add Agent Builder A2A with Agent Framework example app #508
Conversation
|
Review these changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/508 |
carlyrichmond
left a comment
carlyrichmond
left a comment
There was a problem hiding this comment.
Added a few suggestions. It needs to move to the supporting-blog-content. For me the example is too simple for developers, and perhaps adding a more complex dataset may help (similar to https://www.elastic.co/search-labs/blog/ai-agent-builder-elasticsearch)
I'm wondering why this is a script rather than a notebook so it may be worth changing if possible.
|
|
||
| COPY elastic_agent_builder_a2a.py test_elastic_agent_builder_a2a.py ./ | ||
|
|
||
| RUN pip install agent-framework |
There was a problem hiding this comment.
Can you use virtual env and a requirements.txt file to ensure people don't have issues with it breaking for subsequent versions or configuraiton specific to their environment.
|
|
||
|
|
||
| async def main(): | ||
| a2a_agent_host = "<YOUR-ELASTIC-AGENT-BUILDER-URL>" |
There was a problem hiding this comment.
I woudl change this to using env variables that are loaded from the .env file (same for API key as well)
There was a problem hiding this comment.
I find it strange that you have this test in here, but it's not mentioned in the article anywhere. Is there a particular reason for that?
supporting-blog-content/agent-builder-a2a-agent-framework/elastic_agent_builder_a2a.py
Show resolved
Hide resolved
2 participants
Add an example Python console app that demonstrates how to connect and utilize an Elastic Agent Builder agent via the Agent2Agent (A2A) Protocol orchestrated with the Microsoft Agent Framework.