Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WKT Support to Geo #3256

Closed
codebrain opened this issue May 23, 2018 · 1 comment
Closed

Add WKT Support to Geo #3256

codebrain opened this issue May 23, 2018 · 1 comment
Assignees

Comments

@codebrain
Copy link
Contributor

https://www.elastic.co/guide/en/elasticsearch/reference/current/release-notes-6.2.0.html

Two issues to consider:

@codebrain codebrain self-assigned this Jun 18, 2018
@codebrain codebrain added v6.2.1 and removed v6.2.0 labels Jun 25, 2018
@codebrain codebrain changed the title [6.2] Add WKT Support to Geo Add WKT Support to Geo Jun 26, 2018
russcam added a commit that referenced this issue Aug 24, 2018
This commit adds support for Well-Known Text (WKT) representations
of geo_shape. The extent of the implementation is only as far as is
required by the WKT support in Elasticsearch.

Deserialize from WKT to IGeoShape types. The format from which
the shape is deserialized is assigned to an internal format property
on the concrete implementations of GeoShape as the intention is
not to expose this as a property on the IGeoShape interface. The format
is assigned to the instance so that the IGeoShape instance is
serialized to the same format if indexed again.

GeoWKTReader is a simple tokenizer implementation
for the purposes of parsing only WKT concepts that are supported
by Elasticsearch.

GeoShapeConverter now implements WriteJson because the
original format of IGeoShape now needs to be taken into account
when serializing.

Add tests for roundtrip serialization of WKT.

Closes #3256
russcam added a commit that referenced this issue Aug 24, 2018
This commit adds support for Well-Known Text (WKT) representations
of geo_shape. The extent of the implementation is only as far as is
required by the WKT support in Elasticsearch.

Deserialize from WKT to IGeoShape types. The format from which
the shape is deserialized is assigned to an internal format property
on the concrete implementations of GeoShape as the intention is
not to expose this as a property on the IGeoShape interface. The format
is assigned to the instance so that the IGeoShape instance is
serialized to the same format if indexed again.

GeoWKTReader is a simple tokenizer implementation
for the purposes of parsing only WKT concepts that are supported
by Elasticsearch.

GeoShapeConverter now implements WriteJson because the
original format of IGeoShape now needs to be taken into account
when serializing.

Add tests for roundtrip serialization of WKT.

Closes #3256
@russcam russcam added v6.3.0 and removed v6.2.1 labels Aug 24, 2018
russcam added a commit that referenced this issue Aug 27, 2018
* Add support for well known text (wkt) to geo bounding box queries
* Move geo_shape queries into Tests project

This commit moves the geo_shape queries into the Test project.
Missed in the Tests refactoring

* Add support for Z values to GeoCoordinate
* Add support for WKT geo shapes

This commit adds support for Well-Known Text (WKT) representations
of geo_shape. The extent of the implementation is only as far as is
required by the WKT support in Elasticsearch.

Deserialize from WKT to IGeoShape types. The format from which
the shape is deserialized is assigned to an internal format property
on the concrete implementations of GeoShape as the intention is
not to expose this as a property on the IGeoShape interface. The format
is assigned to the instance so that the IGeoShape instance is
serialized to the same format if indexed again.

GeoWKTReader is a simple tokenizer implementation
for the purposes of parsing only WKT concepts that are supported
by Elasticsearch.

GeoShapeConverter now implements WriteJson because the
original format of IGeoShape now needs to be taken into account
when serializing.

Add tests for roundtrip serialization of WKT.

Closes #3256
@russcam
Copy link
Contributor

russcam commented Aug 27, 2018

Closing this as #3377 has been merged into 6.3, to go into 6.x

@russcam russcam closed this as completed Aug 27, 2018
Mpdreamz pushed a commit that referenced this issue Sep 3, 2018
* Add support for well known text (wkt) to geo bounding box queries
* Move geo_shape queries into Tests project

This commit moves the geo_shape queries into the Test project.
Missed in the Tests refactoring

* Add support for Z values to GeoCoordinate
* Add support for WKT geo shapes

This commit adds support for Well-Known Text (WKT) representations
of geo_shape. The extent of the implementation is only as far as is
required by the WKT support in Elasticsearch.

Deserialize from WKT to IGeoShape types. The format from which
the shape is deserialized is assigned to an internal format property
on the concrete implementations of GeoShape as the intention is
not to expose this as a property on the IGeoShape interface. The format
is assigned to the instance so that the IGeoShape instance is
serialized to the same format if indexed again.

GeoWKTReader is a simple tokenizer implementation
for the purposes of parsing only WKT concepts that are supported
by Elasticsearch.

GeoShapeConverter now implements WriteJson because the
original format of IGeoShape now needs to be taken into account
when serializing.

Add tests for roundtrip serialization of WKT.

Closes #3256
Mpdreamz pushed a commit that referenced this issue Sep 3, 2018
* Add support for well known text (wkt) to geo bounding box queries
* Move geo_shape queries into Tests project

This commit moves the geo_shape queries into the Test project.
Missed in the Tests refactoring

* Add support for Z values to GeoCoordinate
* Add support for WKT geo shapes

This commit adds support for Well-Known Text (WKT) representations
of geo_shape. The extent of the implementation is only as far as is
required by the WKT support in Elasticsearch.

Deserialize from WKT to IGeoShape types. The format from which
the shape is deserialized is assigned to an internal format property
on the concrete implementations of GeoShape as the intention is
not to expose this as a property on the IGeoShape interface. The format
is assigned to the instance so that the IGeoShape instance is
serialized to the same format if indexed again.

GeoWKTReader is a simple tokenizer implementation
for the purposes of parsing only WKT concepts that are supported
by Elasticsearch.

GeoShapeConverter now implements WriteJson because the
original format of IGeoShape now needs to be taken into account
when serializing.

Add tests for roundtrip serialization of WKT.

Closes #3256
@Mpdreamz Mpdreamz mentioned this issue Sep 10, 2018
45 tasks
russcam added a commit that referenced this issue Sep 12, 2018
* Add support for well known text (wkt) to geo bounding box queries
* Move geo_shape queries into Tests project

This commit moves the geo_shape queries into the Test project.
Missed in the Tests refactoring

* Add support for Z values to GeoCoordinate
* Add support for WKT geo shapes

This commit adds support for Well-Known Text (WKT) representations
of geo_shape. The extent of the implementation is only as far as is
required by the WKT support in Elasticsearch.

Deserialize from WKT to IGeoShape types. The format from which
the shape is deserialized is assigned to an internal format property
on the concrete implementations of GeoShape as the intention is
not to expose this as a property on the IGeoShape interface. The format
is assigned to the instance so that the IGeoShape instance is
serialized to the same format if indexed again.

GeoWKTReader is a simple tokenizer implementation
for the purposes of parsing only WKT concepts that are supported
by Elasticsearch.

GeoShapeConverter now implements WriteJson because the
original format of IGeoShape now needs to be taken into account
when serializing.

Add tests for roundtrip serialization of WKT.

Closes #3256

(cherry picked from commit f31b087)

Includes line ending sensitive unit test from 0d0afdb
russcam added a commit that referenced this issue Sep 12, 2018
* Add support for well known text (wkt) to geo bounding box queries
* Move geo_shape queries into Tests project

This commit moves the geo_shape queries into the Test project.
Missed in the Tests refactoring

* Add support for Z values to GeoCoordinate
* Add support for WKT geo shapes

This commit adds support for Well-Known Text (WKT) representations
of geo_shape. The extent of the implementation is only as far as is
required by the WKT support in Elasticsearch.

Deserialize from WKT to IGeoShape types. The format from which
the shape is deserialized is assigned to an internal format property
on the concrete implementations of GeoShape as the intention is
not to expose this as a property on the IGeoShape interface. The format
is assigned to the instance so that the IGeoShape instance is
serialized to the same format if indexed again.

GeoWKTReader is a simple tokenizer implementation
for the purposes of parsing only WKT concepts that are supported
by Elasticsearch.

GeoShapeConverter now implements WriteJson because the
original format of IGeoShape now needs to be taken into account
when serializing.

Add tests for roundtrip serialization of WKT.

Closes #3256

(cherry picked from commit f31b087)

Includes line ending sensitive unit test from 0d0afdb
Mpdreamz pushed a commit that referenced this issue Sep 14, 2018
#3401)

* Add support for well known text (wkt) to geo bounding box queries
* Move geo_shape queries into Tests project

This commit moves the geo_shape queries into the Test project.
Missed in the Tests refactoring

* Add support for Z values to GeoCoordinate
* Add support for WKT geo shapes

This commit adds support for Well-Known Text (WKT) representations
of geo_shape. The extent of the implementation is only as far as is
required by the WKT support in Elasticsearch.

Deserialize from WKT to IGeoShape types. The format from which
the shape is deserialized is assigned to an internal format property
on the concrete implementations of GeoShape as the intention is
not to expose this as a property on the IGeoShape interface. The format
is assigned to the instance so that the IGeoShape instance is
serialized to the same format if indexed again.

GeoWKTReader is a simple tokenizer implementation
for the purposes of parsing only WKT concepts that are supported
by Elasticsearch.

GeoShapeConverter now implements WriteJson because the
original format of IGeoShape now needs to be taken into account
when serializing.

Add tests for roundtrip serialization of WKT.

Closes #3256

(cherry picked from commit f31b087)

Includes line ending sensitive unit test from 0d0afdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants