Nested Filter does not allow .Filter only filter

[Philo]

The below query should be supported by NEST, however it results in a conditionless filter being produced.

                Filter<Document>.Nested(n => n
                    .Path("nested_property")
                    .Filter(f => f
                        .Term("nested_property.path", "myvalue")
                    )
                    );

    "filter": {
        "nested": {
           "path": "nested_property",
           "filter" : {
               "term": {
                  "nested_property.path": "myvalue"
               }
        }
    }
}

A workaround is to ensure that you include a .Query(q => q.MatchAll()) within your nested filter.

[Philo]

I will submit a fix via pull request shortly

[jayhilden]

I can confirm that the issue exists, and I can also confirm the workaround of adding ".Query(q => q.MatchAll())"

Here is my non-working search:

        var result = ElasticClient.Search<PackingContainerES>(s =>
            s.Filter(f =>
                f.Or(or => or.Term(t1 => t1.ContainerID, containerID.Value),
                    or2 => or2.Nested(nest =>
                        nest
                            .Path(p => p.InnerContainers)
                            .Filter(nf => nf.Term("innerContainers.containerID", containerID.Value))
                        )
                    )
                )
            );

Here is the working:

        var result = ElasticClient.Search<PackingContainerES>(s =>
            s.Filter(f =>
                f.Or(or => or.Term(t1 => t1.ContainerID, containerID.Value),
                    or2 => or2.Nested(nest =>
                        nest
                            .Query(q => q.MatchAll())
                            .Path(p => p.InnerContainers)
                            .Filter(nf => nf.Term("innerContainers.containerID", containerID.Value))
                        )
                    )
                )
            );

[gmarz]

Thanks for confirming @jayhilden. #881 will fix this, just waiting for the CLA so I can merge it in.

[gmarz]

Closed by #881