-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/6.0 breaking changes #2944
Conversation
Document API Changes - version type force remove - Deleted enum value - found field removed in the Delete API - Deleted property Mapping Changes - The include_in_all mapping parameter is now disallowed - Deleted all IncludeInAll and include_in_all references
…ord_len (a synonym for max_word_length) have been removed.
Analyze API can analyze normalizer and custom normalizer. In previous versions of Elasticsearch, Analyze API is requiring a tokenizer or analyzer parameter. In Elasticsearch 6.0.0, Analyze API can analyze a text as a keyword field with custom normalizer or if char_filter/filter is set and tokenizer/analyzer is not set.
…tion has been removed from the distance_type parameter.
…been removed. If provided, it will be ignored and issue a deprecation warning.
… removed. If provided, it will be ignored and issue a deprecation warning. The query_string query now splits on operator only.
…. If provided, it will be ignored and issue a deprecation warning. The tie_breaker parameter must be used instead.
… has been removed, use an explicit quoted query instead. If provided, it will be ignored and issue a deprecation warning.
…removed from simple_query_string.
…nstant_score_filter (synonyms for constant_score) have been removed.
…ch. The unified highlighter outputs the same highlighting when index_options is set to offsets.
…e.throttle.type and indices.store.throttle.max_bytes_per_sec cluster settings and the index.store.throttle.type and index.store.throttle.max_bytes_per_sec index settings are not recognized anymore.
…ing has been removed, the store stats do not report throttle_time anymore.
Elasticsearch has defaulted to assuming that it is running on SSDs since the 2.x series of Elasticsearch. As such, Elasticsearch no longer needs to collect information from the operating system as to whether or not the underlying disks of each data path spin or not. While this functionality was no longer needed starting in the 2.x series of Elasticsearch, it was maintained in the filesystem section of the nodes stats APIs. This information has now been removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from some super pedantic comment.
I think its best not to try and merge the target branch on an open PR as with this commit but rather to rebase it in the future.
///<summary>A collection of filters to use for the analysis</summary> | ||
public string[] Filter { get; set; } | ||
/// <inheritdoc /> | ||
public string[] Filter { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spaces instead of tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -21,7 +21,7 @@ public enum RewriteMultiTerm | |||
/// <summary> | |||
/// A rewrite method that first translates each term into a should clause in a boolean query, and keeps the scores | |||
/// as computed by the query. Note that typically such scores are meaningless to the user, and require non-trivial | |||
/// CPU to compute, so it’s almost always better to use constant_score_auto. This rewrite method will hit too many |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch 👍
First set of changes from #2923