Correctly deserialize JoinField #3357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the join field is a string and using JsonNetSerializer, the string conversion should not emit the surrounding double quotes Closes #3356
Mpdreamz
requested changes
Aug 12, 2018
| [U] | ||
| public void JoinFieldDeserializedCorrectly() | ||
| { | ||
| var pool = new SingleNodeConnectionPool(new Uri("http://localhost:9200")); |
There was a problem hiding this comment.
LGTM small suggestion though is to use the recently centralized json serialization assertions.
var tester = SerializationTester.DefaultWithSourceSerializer;
var response = tester.Client.IndexDocument(doc);
tester.AssertSerialize(response.ApiCall.RequestBodyInBytes, new { join = "parent" });
var doc = tester.AssertDeserialize<MyDocument>(response.ApiCall.RequestBodyInBytes);There was a problem hiding this comment.
SerializationTester.DefaultWithSourceSerializer;
Would need to be added though
There was a problem hiding this comment.
Could even use only AssertRoundTrip<MyDocument>() rather than AssertSerialize and AssertDeserialize separately
Update following PR
Mpdreamz
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the join field is a string and using JsonNetSerializer, the string
conversion should not emit the surrounding double quotes
Closes #3356