Fix #3323 Add support for null_value, ignore_z_value on GeoPoint prop… #3364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
suggested changes
Aug 20, 2018
| GeoLocation IGeoPointProperty.NullValue { get; set; } | ||
|
|
||
| public bool IgnoreMalformed { get => Self.IgnoreMalformed.GetValueOrDefault(); set => Self.IgnoreMalformed = value; } | ||
| public bool IgnoreZValue { get => Self.IgnoreZValue.GetValueOrDefault(); set => Self.IgnoreZValue= value; } |
There was a problem hiding this comment.
I think this should be Self.IgnoreZValue.GetValueOrDefault(true), in line with the default value in Elasticsearch
russcam
approved these changes
Aug 20, 2018
Mpdreamz
added a commit
that referenced
this pull request
Sep 3, 2018
#3364) This commit adds support for null_value, ignore_z_value on GeoPoint property
Mpdreamz
added a commit
that referenced
this pull request
Sep 3, 2018
#3364) This commit adds support for null_value, ignore_z_value on GeoPoint property
Mpdreamz
added a commit
that referenced
this pull request
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erty