Skip to content

Conversation

Mpdreamz
Copy link
Member

No description provided.

Omitting `context` for now since that only takes a single option now
which is also the default. Waiting for the API to crystalize here.
@Mpdreamz Mpdreamz changed the title Feature/painless script execute api 6.3 Fix #3320 Add Painles script execute API Aug 13, 2018
@Mpdreamz Mpdreamz changed the title Fix #3320 Add Painles script execute API Fix #3320 Add Painless script execute API Aug 13, 2018
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

{
[JsonProperty("script")]
IInlineScript Script { get; set; }
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing Context?

https://www.elastic.co/guide/en/elasticsearch/painless/current/painless-execute-api.html

Can be added later though, as there is only one context at this point

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, just seen the commit message 😄

@russcam russcam merged commit 9e07d93 into 6.3 Aug 20, 2018
@russcam russcam deleted the feature/painless-script-execute-api-6.3 branch August 24, 2018 06:47
@Mpdreamz Mpdreamz mentioned this pull request Sep 3, 2018
45 tasks
Mpdreamz added a commit that referenced this pull request Sep 3, 2018
* Generate ExcecutePainlessScript methods/descriptors etc

* Implement ExecutePainlessScript API with tests

Omitting `context` for now since that only takes a single option now
which is also the default. Waiting for the API to crystalize here.

* make Result generic in preparation for 6.4
Mpdreamz added a commit that referenced this pull request Sep 3, 2018
* Generate ExcecutePainlessScript methods/descriptors etc

* Implement ExecutePainlessScript API with tests

Omitting `context` for now since that only takes a single option now
which is also the default. Waiting for the API to crystalize here.

* make Result generic in preparation for 6.4
Mpdreamz added a commit that referenced this pull request Sep 6, 2018
* Generate ExcecutePainlessScript methods/descriptors etc

* Implement ExecutePainlessScript API with tests

Omitting `context` for now since that only takes a single option now
which is also the default. Waiting for the API to crystalize here.

* make Result generic in preparation for 6.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants