Fix #3320 Add Painless script execute API #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omitting `context` for now since that only takes a single option now which is also the default. Waiting for the API to crystalize here.
Mpdreamz
changed the title
Mpdreamz
changed the title
russcam
approved these changes
Aug 20, 2018
| { | ||
| [JsonProperty("script")] | ||
| IInlineScript Script { get; set; } | ||
| } |
There was a problem hiding this comment.
missing Context?
https://www.elastic.co/guide/en/elasticsearch/painless/current/painless-execute-api.html
Can be added later though, as there is only one context at this point
There was a problem hiding this comment.
Nevermind, just seen the commit message 😄
Mpdreamz
added a commit
that referenced
this pull request
Sep 3, 2018
* Generate ExcecutePainlessScript methods/descriptors etc * Implement ExecutePainlessScript API with tests Omitting `context` for now since that only takes a single option now which is also the default. Waiting for the API to crystalize here. * make Result generic in preparation for 6.4
Mpdreamz
added a commit
that referenced
this pull request
Sep 3, 2018
* Generate ExcecutePainlessScript methods/descriptors etc * Implement ExecutePainlessScript API with tests Omitting `context` for now since that only takes a single option now which is also the default. Waiting for the API to crystalize here. * make Result generic in preparation for 6.4
Mpdreamz
added a commit
that referenced
this pull request
Sep 6, 2018
* Generate ExcecutePainlessScript methods/descriptors etc * Implement ExecutePainlessScript API with tests Omitting `context` for now since that only takes a single option now which is also the default. Waiting for the API to crystalize here. * make Result generic in preparation for 6.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.