Skip to content

Add MatchPattern to dynamic templates #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2018
Merged

Add MatchPattern to dynamic templates #3374

merged 1 commit into from
Aug 23, 2018

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Aug 20, 2018

Closes #3373

Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - wondering if the framework change was required.

@@ -7,7 +7,7 @@
<NoWarn>$(NoWarn);xUnit1013</NoWarn>
</PropertyGroup>
<ItemGroup>
<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.0-beta1-build3642" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet xunit 2.3.1 does not play properly with running tests from the command line - it cannot find the dotnet SDK. Reverted change back

@russcam russcam merged commit 8af0883 into 6.3 Aug 23, 2018
@russcam russcam deleted the fix/3373 branch August 24, 2018 06:46
@Mpdreamz Mpdreamz mentioned this pull request Sep 3, 2018
45 tasks
Mpdreamz pushed a commit that referenced this pull request Sep 3, 2018
Mpdreamz pushed a commit that referenced this pull request Sep 3, 2018
Mpdreamz pushed a commit that referenced this pull request Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants