Skip to content

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Aug 27, 2018

This commit adds a note to the filter_path XML comments to warn about
response filtering potentially affecting deserialization to the respective response type.

Include XML comments on common options for Descriptor types

Closes #3331

This commit adds a note to the filter_path XML comments to warn about
response filtering potentially affecting deserialization to the respective response type.

Include XML comments on common options for Descriptor types

Closes #3331
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam russcam merged commit f7de3d1 into 6.3 Aug 29, 2018
@Mpdreamz Mpdreamz mentioned this pull request Sep 3, 2018
45 tasks
Mpdreamz pushed a commit that referenced this pull request Sep 3, 2018
This commit adds a note to the filter_path XML comments to warn about
response filtering potentially affecting deserialization to the respective response type.

Include XML comments on common options for Descriptor types

Closes #3331
Mpdreamz pushed a commit that referenced this pull request Sep 3, 2018
This commit adds a note to the filter_path XML comments to warn about
response filtering potentially affecting deserialization to the respective response type.

Include XML comments on common options for Descriptor types

Closes #3331
Mpdreamz pushed a commit that referenced this pull request Sep 6, 2018
This commit adds a note to the filter_path XML comments to warn about
response filtering potentially affecting deserialization to the respective response type.

Include XML comments on common options for Descriptor types

Closes #3331

(cherry picked from commit 0f6aac0)
@russcam russcam deleted the feature/3331 branch October 18, 2018 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants