Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about filter_path and deserialization #3379

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Add note about filter_path and deserialization #3379

merged 1 commit into from
Aug 29, 2018

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Aug 27, 2018

This commit adds a note to the filter_path XML comments to warn about
response filtering potentially affecting deserialization to the respective response type.

Include XML comments on common options for Descriptor types

Closes #3331

@russcam
Add note about filter_path and deserialization
0b0d19c 
This commit adds a note to the filter_path XML comments to warn about
response filtering potentially affecting deserialization to the respective response type.

Include XML comments on common options for Descriptor types

Closes #3331
@russcam russcam mentioned this pull request Aug 27, 2018
Closed
@russcam russcam requested review from Mpdreamz and codebrain August 29, 2018 00:42
codebrain
codebrain approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam russcam merged commit f7de3d1 into 6.3 Aug 29, 2018
@Mpdreamz Mpdreamz mentioned this pull request Sep 3, 2018
Closed
45 tasks
Mpdreamz pushed a commit that referenced this pull request Sep 3, 2018
@russcam @Mpdreamz
Add note about filter_path and deserialization (#3379)
0f6aac0 
This commit adds a note to the filter_path XML comments to warn about
response filtering potentially affecting deserialization to the respective response type.

Include XML comments on common options for Descriptor types

Closes #3331
Mpdreamz pushed a commit that referenced this pull request Sep 3, 2018
@russcam @Mpdreamz
Add note about filter_path and deserialization (#3379)
fa61bfb 
This commit adds a note to the filter_path XML comments to warn about
response filtering potentially affecting deserialization to the respective response type.

Include XML comments on common options for Descriptor types

Closes #3331
Mpdreamz pushed a commit that referenced this pull request Sep 6, 2018
@russcam @Mpdreamz
Add note about filter_path and deserialization (#3379)
b32db59 
This commit adds a note to the filter_path XML comments to warn about
response filtering potentially affecting deserialization to the respective response type.

Include XML comments on common options for Descriptor types

Closes #3331

(cherry picked from commit 0f6aac0)
@russcam russcam deleted the feature/3331 branch October 18, 2018 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebrain codebrain codebrain approved these changes

@Mpdreamz Mpdreamz Awaiting requested review from Mpdreamz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russcam @codebrain