Obsolete HttpWebRequestConnection on .NET Core #3391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port it, rely on DOTNETCORE pragma only
…proach, reformatted Solution items and moved scripts out of Solution items
…a which was never used
…ttpClient instances
…GE pragma which was never used" This reverts commit da2d826.
Mpdreamz
changed the title
Mpdreamz
added a commit
that referenced
this pull request
Sep 6, 2018
* FEATURE_HTTP_WEB_REQUEST is outdated both netstandard2x and net4x support it, rely on DOTNETCORE pragma only * update .editorconfig to make sure props and targets are formatted like xml and csproj * Move away from Directory.build.props for a more explicit inclusion approach, reformatted Solution items and moved scripts out of Solution items * Remove random old connection usage and add explict net461 testing back * Remove Tests\Directory.build.props it set a TESTINGNUGETPACKAGE pragma which was never used * cleanup namespaces on full .net HttpConnection alias class * Obsolete HttpWebRequestConnection on CoreFX since it does not reuse HttpClient instances * Revert "Remove Tests\Directory.build.props it set a TESTINGNUGETPACKAGE pragma which was never used" This reverts commit da2d826. * Remove setting of the TESTINGNUGETPACKAGE constant, not used anywher * Comment looping up for Directory.build.props for now * Add root Directory.build.props (for now only sets LangVersion to latest) (cherry picked from commit 8ca1e0b)
Mpdreamz
added a commit
that referenced
this pull request
Sep 10, 2018
* FEATURE_HTTP_WEB_REQUEST is outdated both netstandard2x and net4x support it, rely on DOTNETCORE pragma only * update .editorconfig to make sure props and targets are formatted like xml and csproj * Move away from Directory.build.props for a more explicit inclusion approach, reformatted Solution items and moved scripts out of Solution items * Remove random old connection usage and add explict net461 testing back * Remove Tests\Directory.build.props it set a TESTINGNUGETPACKAGE pragma which was never used * cleanup namespaces on full .net HttpConnection alias class * Obsolete HttpWebRequestConnection on CoreFX since it does not reuse HttpClient instances * Revert "Remove Tests\Directory.build.props it set a TESTINGNUGETPACKAGE pragma which was never used" This reverts commit da2d826. * Remove setting of the TESTINGNUGETPACKAGE constant, not used anywher * Comment looping up for Directory.build.props for now * Add root Directory.build.props (for now only sets LangVersion to latest) (cherry picked from commit 8ca1e0b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
HttpConnectionon .NET core is one that usesHttpClient.The default
HttpConnectionfull .NET (4.x) is one that usesHttpWebRequest. ``HttpConnectionhere is an alias forHttpWebRequestConnection`.We switched to testing only
netcoreapp2.1and randomly selecting eitherHttpConnectionorHttpWebRequestConnection. However HttpWebRequest implementation on CoreFx is pretty naive in itsHttpClientusage and we see it leak sockets on our CI environment a lot (TCP connections inTIME_WAITbuilding up).This reverts the changes to our testing setup and explicitly tests
netcoreapp2.1andnet461` again.