Allow derived implementations of ConnectionSettingsAwareContractResolver #3599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows derived implementations of ConnectionSettingsAwareContractResolver to be specified when creating a derived ConnectionSettingsAwareSerializerBase. This can be useful when wishing to include Type information in the serialized JSON. Add documentation to demonstrate how to use. Closes #3494
codebrain
approved these changes
Mar 15, 2019
Contributor
codebrain
left a comment
codebrain
left a comment
There was a problem hiding this comment.
LGTM, minor comment on the type name as a string.
| //json | ||
| var expected = new JObject | ||
| { | ||
| { "$type", "Tests.ClientConcepts.HighLevel.Serialization.GettingStarted+MyDocument, Tests" }, |
Contributor
Author
There was a problem hiding this comment.
nameof only resolves to the leaf value sadly. Could use AssemblyQualifiedName and strip everything after assembly name (seems easiest way)
Contributor
Author
There was a problem hiding this comment.
Will keep as string because the JObject is serialized to JSON in documentation and other approaches complicate this.
russcam
added a commit
that referenced
this pull request
Mar 20, 2019
…ver (#3599) This commit allows derived implementations of ConnectionSettingsAwareContractResolver to be specified when creating a derived ConnectionSettingsAwareSerializerBase. This can be useful when wishing to include Type information in the serialized JSON. Add documentation to demonstrate how to use. Closes #3494
russcam
added a commit
that referenced
this pull request
Mar 21, 2019
…ver (#3599) This commit allows derived implementations of ConnectionSettingsAwareContractResolver to be specified when creating a derived ConnectionSettingsAwareSerializerBase. This can be useful when wishing to include Type information in the serialized JSON. Add documentation to demonstrate how to use. Closes #3494
russcam
added a commit
that referenced
this pull request
Apr 2, 2019
…ver (#3599) This commit allows derived implementations of ConnectionSettingsAwareContractResolver to be specified when creating a derived ConnectionSettingsAwareSerializerBase. This can be useful when wishing to include Type information in the serialized JSON. Add documentation to demonstrate how to use. Closes #3494 (cherry picked from commit f72d9ac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows derived implementations of ConnectionSettingsAwareContractResolver
to be specified when creating a derived ConnectionSettingsAwareSerializerBase. This can
be useful when wishing to include Type information in the serialized JSON.
Add documentation to demonstrate how to use.
Closes #3494