Move to .NET 3.0 and C# 8.0 (#4097) #4101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial move to .NET Core 3.0 * bump to .net sdk 3.0.100 and update our build files to install it for now while the images catch up * move scripts to 3.0 since we call dotnet run on them, exclude new types from codestandards test that all types live in Elasticsearch.Net/NEST namespace * build tooling moved from 2.2 to 3.0 * move all netcoreapp over to 3.0 * move to range on RegexCollection no longer accepts Last() * update our own dependencies * make 2.2 available for canary so that rewrite using 2.2 tools still works * fix yaml indentation * disable ingest-attachemnt for now, installl has stderr on 8.0.0 which abstractions does not yet handle * move rewriter and differ to local dotnet tools * no longer need to install 2.2 sdk for differ (cherry picked from commit 9bbffad)
Member
Author
|
Two integration test failures one is due to the seed opened #4104 to fix that. The other is a
|
Member
Author
|
Since the doc generation PR is now pending as per #4113 moving ahead and merging this in. |
russcam
pushed a commit
that referenced
this pull request
Oct 1, 2019
* Move to .NET 3.0 and C# 8.0 (#4097) * initial move to .NET Core 3.0 * bump to .net sdk 3.0.100 and update our build files to install it for now while the images catch up * move scripts to 3.0 since we call dotnet run on them, exclude new types from codestandards test that all types live in Elasticsearch.Net/NEST namespace * build tooling moved from 2.2 to 3.0 * move all netcoreapp over to 3.0 * move to range on RegexCollection no longer accepts Last() * update our own dependencies * make 2.2 available for canary so that rewrite using 2.2 tools still works * fix yaml indentation * disable ingest-attachemnt for now, installl has stderr on 8.0.0 which abstractions does not yet handle * move rewriter and differ to local dotnet tools * no longer need to install 2.2 sdk for differ (cherry picked from commit 9bbffad) * update Elastic.* packages and reenable attachment plugin on writable cluster * same elastic version as other branhces * NuGet.config and nuget.config both existed in the repos * update to latest abstractions that is more lenient on stderr from plugin installs * update abstractions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial move to .NET Core 3.0
bump to .net sdk 3.0.100 and update our build files to install it for now while the images catch up
move scripts to 3.0 since we call dotnet run on them, exclude new types from codestandards test that all types live in Elasticsearch.Net/NEST namespace
build tooling moved from 2.2 to 3.0
move all netcoreapp over to 3.0
move to range on RegexCollection no longer accepts Last()
update our own dependencies
make 2.2 available for canary so that rewrite using 2.2 tools still works
fix yaml indentation
disable ingest-attachemnt for now, installl has stderr on 8.0.0 which abstractions does not yet handle
move rewriter and differ to local dotnet tools
no longer need to install 2.2 sdk for differ
(cherry picked from commit 9bbffad)