Skip to content

Fix issue with extended_stats aggregation on datetime field #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benbenwilde wants to merge 2 commits into from
Closed

Fix issue with extended_stats aggregation on datetime field #4103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0319c1b
Fix issue with extended_stats aggregation on datetime field
benbenwilde Sep 26, 2019
bc2ff70
Also apply the fix for parsing the end of an extended_stats response.
benbenwilde Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/Nest/Aggregations/AggregateJsonConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,7 @@ private IAggregate GetStatsAggregate(JsonReader reader, JsonSerializer serialize
if (reader.TokenType == JsonToken.EndObject)
return statsMetric;

var propertyName = (string)reader.Value;
while (reader.TokenType != JsonToken.EndObject && propertyName.Contains(Parser.AsStringSuffix))
while (reader.TokenType != JsonToken.EndObject && ((string)reader.Value).Contains(Parser.AsStringSuffix))
{
reader.Read();
reader.Read();
Expand Down Expand Up @@ -397,11 +396,10 @@ private IAggregate GetExtendedStatsAggregate(StatsAggregate statsMetric, JsonRea
reader.Read();
}

propertyName = (string)reader.Value;
while (reader.TokenType != JsonToken.EndObject && propertyName.Contains(Parser.AsStringSuffix))
while (reader.TokenType != JsonToken.EndObject && ((string)reader.Value).Contains(Parser.AsStringSuffix))
{
// std_deviation_bounds is an object, so we need to skip its properties
if (propertyName.Equals(Parser.StdDeviationBoundsAsString))
if (((string)reader.Value).Equals(Parser.StdDeviationBoundsAsString))
{
reader.Read();
reader.Read();
Expand Down