Implement shape property type mapping. #4154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
approved these changes
Oct 17, 2019
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
LGTM, just need to implement some SkipVersions. might be worth rebasing against 7.x as several test fixes went into there today
src/Tests/Tests/Indices/MappingManagement/PutMapping/PutMappingApiTest.cs
Show resolved
Hide resolved
Implement shape queries.
Implement shape queries.
…csearch-net into feature/7.x/shape-mapping
codebrain
added a commit
that referenced
this pull request
Oct 18, 2019
Mpdreamz
added a commit
that referenced
this pull request
Oct 21, 2019
Mpdreamz
added a commit
that referenced
this pull request
Oct 21, 2019
* fix #4154 should be more version independent * fix putmapping API test now that [Shape] is no longer attributed on ArbitraryShape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: elastic/elasticsearch#43644