-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add histogram datatype #4367
Add histogram datatype #4367
Conversation
This commit adds the histogram datatype to the client. The histogram datatype is available in Elasticsearch 7.6.0+ with at least a basic license level Closes #4358
I did consider adding a type to be able to index histogram values and counts. Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The docs (https://www.elastic.co/guide/en/elasticsearch/reference/7.x/histogram.html) indicate the format for indexing is quite simple:
I think a type to index this is probably worth it and quite simple to implement? |
A type used for indexing would be good, however we would also need to make sure it works well with |
It being a simple type was my reason to not implement it 😄 Could add one in a follow up PR? |
This commit adds the histogram datatype to the client. The histogram datatype
is available in Elasticsearch 7.6.0+ with at least a basic license level
Closes #4358