Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add per-field metadata #4376

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Add per-field metadata #4376

merged 2 commits into from
Feb 10, 2020

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Feb 6, 2020

Relates: #4341

This commit adds the ability to define per-field metadata in mappings,
which will be returned via the Get Mapping API and Field Capabilities API.

@russcam
Copy link
Contributor Author

russcam commented Feb 6, 2020 •
edited
Loading

This technically introduces a binary breaking change as it introduces the Meta property on IProperty. There's a reasonable chance that a user has implemented this interface for a custom property for a custom plugin, for example.

An alternative is to introduce the Meta property on a separate interface in 7.x, and include on IProperty in master. Thoughts @Mpdreamz, @codebrain?

@russcam russcam mentioned this pull request Feb 6, 2020
Closed
@codebrain
Copy link
Contributor

IProperty is likely used by others for custom properties, so would suggest adding to a new interface for the time being and then unify in 8.0.

Mpdreamz
Mpdreamz approved these changes Feb 7, 2020
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz
Copy link
Member

Mpdreamz commented Feb 7, 2020

I'm okay with adding the property on IProperty, yes its breaking but similarly if new properties appear on ISearchRequest we would not introduce more interfaces.

Most of these interfaces are for for DTO, not behavioral components.

@russcam
Copy link
Contributor Author

russcam commented Feb 10, 2020

I'm OK with including it in 7.x, so long as we explicitly call out in the release notes for 7.6.0 👍

@russcam
Add per-field metadata
a92b5f5 
Relates: #4341

This commit adds the ability to define per-field metadata in mappings,
which will be returned via the Get Mapping API and Field Capabilities API.
@russcam
Delete unused abstract metafields base class
76bc82c
@russcam russcam force-pushed the feature/7x/field-meta branch from 1df8ce0 to 76bc82c Compare February 10, 2020 01:39
@russcam
Copy link
Contributor Author

russcam commented Feb 10, 2020

rebased on top of 7.x for a green test run

@russcam russcam merged commit 9bc7470 into 7.x Feb 10, 2020
russcam added a commit that referenced this pull request Feb 10, 2020
@russcam
Add per-field metadata (#4376)
3b7a847 
Relates: #4341

This commit adds the ability to define per-field metadata in mappings,
which will be returned via the Get Mapping API and Field Capabilities API.

(cherry picked from commit 9bc7470)
@russcam
Copy link
Contributor Author

russcam commented Feb 10, 2020

ported to master 3b7a847

@Mpdreamz Mpdreamz deleted the feature/7x/field-meta branch February 10, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russcam @codebrain @Mpdreamz