Add special serialization handling for nullable ValueTuples #4713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds special serialization handling for nullable ValueTuples. Specialized handling is required as without, a nullable ValueTuple type ends up falling into CustomDyanmicObjectResolver inside of NestFormatterResolver, which will build a dynamic formatter using MetaType et.al, which enumerates interfaces and can cause a CLR error when calling `at System.Runtime.CompilerServices.ITuple.get_Length()`. Fixes #4703
|
rebased on top of master |
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2020
This commit adds special serialization handling for nullable ValueTuples. Specialized handling is required as without, a nullable ValueTuple type ends up falling into CustomDyanmicObjectResolver inside of NestFormatterResolver, which will build a dynamic formatter using MetaType et.al, which enumerates interfaces and can cause a CLR error when calling `at System.Runtime.CompilerServices.ITuple.get_Length()`. Fixes #4703
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2020
This commit adds special serialization handling for nullable ValueTuples. Specialized handling is required as without, a nullable ValueTuple type ends up falling into CustomDyanmicObjectResolver inside of NestFormatterResolver, which will build a dynamic formatter using MetaType et.al, which enumerates interfaces and can cause a CLR error when calling `at System.Runtime.CompilerServices.ITuple.get_Length()`. Fixes #4703
russcam
added a commit
that referenced
this pull request
May 27, 2020
…4715) This commit adds special serialization handling for nullable ValueTuples. Specialized handling is required as without, a nullable ValueTuple type ends up falling into CustomDyanmicObjectResolver inside of NestFormatterResolver, which will build a dynamic formatter using MetaType et.al, which enumerates interfaces and can cause a CLR error when calling `at System.Runtime.CompilerServices.ITuple.get_Length()`. Fixes #4703 Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam
added a commit
that referenced
this pull request
May 27, 2020
…4716) This commit adds special serialization handling for nullable ValueTuples. Specialized handling is required as without, a nullable ValueTuple type ends up falling into CustomDyanmicObjectResolver inside of NestFormatterResolver, which will build a dynamic formatter using MetaType et.al, which enumerates interfaces and can cause a CLR error when calling `at System.Runtime.CompilerServices.ITuple.get_Length()`. Fixes #4703 Co-authored-by: Russ Cam <russ.cam@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds special serialization handling for nullable
ValueTuples. Specialized handling is required as without, a nullableValueTupletype ends up falling intoCustomDynamicObjectResolverinside ofNestFormatterResolver, which will build a dynamic formatter usingMetaTypeet.al, which enumerates interfaces and can cause a CLR error when callingSystem.Runtime.CompilerServices.ITuple.get_Length().Fixes #4703