Fix missing deprecated attributes on low-level #5120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identified a bug after creating a patch and regenerating code where the low level generate code was not rendering deprecated attributes for some methods. The deduping logic handles aliases but does not handle non-aliased paths which is corrected by doing a final check to prefer the deprecated versions. Additional: - Updated the version of Spectre.Console - Fixed breaking change from Spectre.Console
Mpdreamz
requested changes
Nov 26, 2020
Mpdreamz
approved these changes
Nov 26, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Nov 26, 2020
* Fix missing deprecated attributes on low-level Identified a bug after creating a patch and regenerating code where the low level generate code was not rendering deprecated attributes for some methods. The deduping logic handles aliases but does not handle non-aliased paths which is corrected by doing a final check to prefer the deprecated versions. Additional: - Updated the version of Spectre.Console - Fixed breaking change from Spectre.Console * Apply code review feedback
github-actions bot
pushed a commit
that referenced
this pull request
Nov 26, 2020
* Fix missing deprecated attributes on low-level Identified a bug after creating a patch and regenerating code where the low level generate code was not rendering deprecated attributes for some methods. The deduping logic handles aliases but does not handle non-aliased paths which is corrected by doing a final check to prefer the deprecated versions. Additional: - Updated the version of Spectre.Console - Fixed breaking change from Spectre.Console * Apply code review feedback
stevejgordon
added a commit
that referenced
this pull request
Nov 30, 2020
* Fix missing deprecated attributes on low-level Identified a bug after creating a patch and regenerating code where the low level generate code was not rendering deprecated attributes for some methods. The deduping logic handles aliases but does not handle non-aliased paths which is corrected by doing a final check to prefer the deprecated versions. Additional: - Updated the version of Spectre.Console - Fixed breaking change from Spectre.Console * Apply code review feedback Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon
added a commit
that referenced
this pull request
Nov 30, 2020
* Fix missing deprecated attributes on low-level Identified a bug after creating a patch and regenerating code where the low level generate code was not rendering deprecated attributes for some methods. The deduping logic handles aliases but does not handle non-aliased paths which is corrected by doing a final check to prefer the deprecated versions. Additional: - Updated the version of Spectre.Console - Fixed breaking change from Spectre.Console * Apply code review feedback Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified a bug after creating a patch and regenerating code where the low level generate code was not rendering deprecated attributes for some methods.
The deduping logic handles aliases but does not handle non-aliased paths which is corrected by doing a final check to prefer the deprecated versions.
As far as I can tell by running the generator locally, this change doesn't seem to negatively affect any other parts of the code generation.
Additional: