Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WithAlias extensions for CreateIndexRequestDescriptor #8373

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Add WithAlias extensions for CreateIndexRequestDescriptor #8373

merged 3 commits into from
Oct 11, 2024
+56 −3

Conversation

stevejgordon
Copy link
Contributor

This improves the developer experience with extension methods to simplify adding alias(es) to an index at creation time using the CreateIndexRequestDescriptor and CreateIndexRequestDescriptor<T>.

This also fixes up some incorrect namespaces in some of the manual files.

@flobernd flobernd merged commit bcd4d0d into main Oct 11, 2024
23 of 24 checks passed
@flobernd flobernd deleted the enhancement-withalias branch October 11, 2024 14:01
github-actions bot pushed a commit that referenced this pull request Oct 11, 2024
@stevejgordon @github-actions
Add WithAlias extensions for CreateIndexRequestDescriptor (#8373)
14e1351 
* Add WithAlias extension methods for CreateIndexRequestDescriptor

* Fix incorrect namespaces in manual code files

* Remove params overloads (for now)
@github-actions github-actions bot mentioned this pull request Oct 11, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Oct 11, 2024
@stevejgordon @github-actions
Add WithAlias extensions for CreateIndexRequestDescriptor (#8373)
c295e92 
* Add WithAlias extension methods for CreateIndexRequestDescriptor

* Fix incorrect namespaces in manual code files

* Remove params overloads (for now)
@github-actions github-actions bot mentioned this pull request Oct 11, 2024
Merged
flobernd pushed a commit that referenced this pull request Oct 11, 2024
@github-actions @stevejgordon
Add WithAlias extensions for CreateIndexRequestDescriptor (#8373) (#…
83b0d39 
…8385)

* Add WithAlias extension methods for CreateIndexRequestDescriptor

* Fix incorrect namespaces in manual code files

* Remove params overloads (for now)

Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
flobernd pushed a commit that referenced this pull request Oct 11, 2024
@github-actions @stevejgordon
Add WithAlias extensions for CreateIndexRequestDescriptor (#8373) (#…
0444ee4 
…8386)

* Add WithAlias extension methods for CreateIndexRequestDescriptor

* Fix incorrect namespaces in manual code files

* Remove params overloads (for now)

Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flobernd flobernd Awaiting requested review from flobernd

Assignees
No one assigned
Labels
8.x Relates to 8.x client version Area: Client backport serverless backport 8.x Category: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevejgordon @flobernd