Skip to content

NoAliveException not moved to new namespace #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
panvid opened this issue Mar 29, 2022 · 2 comments
Closed

NoAliveException not moved to new namespace #1209

panvid opened this issue Mar 29, 2022 · 2 comments
Labels

Comments

@panvid
Copy link

panvid commented Mar 29, 2022

The new major version 8.0.0 provides a new Namespace for Eceptions: Elastic\ElasticSearch\Exception.

I found an Exception, which is missed move to the new namespace in Incides-Endpoint: https://github.com/elastic/elasticsearch-php/blob/8.0/src/Endpoints/Indices.php#L23

use Elastic\Transport\Exception\NoAliveException;
@ezimuel
Copy link
Contributor

ezimuel commented Mar 30, 2022

@panvid thanks for reporting the issue. It's a typo since it should be NoNodeAvailableException. This is an exception of elastic/elastic-transport-php so it's ok to have it under Elastic\Transport\Exception. Since this is a generated code I need to fix the code generator and I'll release a 8.0.1 soon.

@ezimuel ezimuel added the bug label Mar 30, 2022
@ezimuel
Copy link
Contributor

ezimuel commented Mar 30, 2022

@panvid I just fixed the issue and released v8.0.1

@ezimuel ezimuel closed this as completed Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants