Invalid type given as required for multiple methods

[AJenbo]

elasticsearch-php/src/Traits/ClientEndpointsTrait.php

Line 39 in c9a5c85

* refresh: enum, // If `true` then refresh the affected shards to make this operation visible to search, if `wait_for` then wait for a refresh to make this operation visible to search, if `false` (the default) then do nothing with refreshes.

enum is not a valid PHP type, the correct type for a generic enum is \UnitEnum, you probably just want string.

number is not a valid type, the correct one is numeric if you want int|float|numeric-string.

list is used for comma-separated lists, this should be string, but comment might be misleading as it appears it might accept both, in which case string|list would be better.

long is not a valid type, use int

time is not a valid type, use \DateTime, int or string

[MidnightDesign]

This has been a issue for almost 2 years, but nobody is responding.

[AJenbo]

This has been a issue for almost 2 years, but nobody is responding.

Have you figured out what is used to generate the code?

[MidnightDesign]

I think had found it at some point, but I don't know right now.

[momala454]

https://github.com/elastic/elasticsearch/blob/113f0c17cc48913225d5c9e4e06ebb44a3a56e14/rest-api-spec/src/main/resources/rest-api-spec/api/_common.json#L28

this contains the comment and "type" in all of those json files, so maybe changing here to like list|string instead of list may work. I don't know where it's generated, or how to change it to optional

[AJenbo]

I was unable to figure out what they use to generate the code.

[ezimuel]

@AJenbo, @momala454, @MidnightDesign the code generator is not part of this repository. I'm working to fix the PHPStan issues and I'll let you know asap. Thanks for your patience.

[AJenbo]

... right, but what repo is it in?

[MidnightDesign]

@ezimuel Thank you for the response. I am aware that it's not here. Where is it?

[AJenbo]

For completeness he clarified that the generator is not publicly avalible.

[ezimuel]

I added a CONTRIBUTING guide where I explained the @generated tag. I hope this will help with future contributions. Thanks for your feedback.

[ezimuel]

I just sent this PR #1439 to fix the issue