Skip to content

[DOCS] Added compatibility section in doc + updated release notes #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2021
Merged

[DOCS] Added compatibility section in doc + updated release notes #1163

merged 2 commits into from
Sep 14, 2021

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Sep 13, 2021

This PR provides the following changes in the documentation:

  • added a compatibility section;
  • updated the release notes up to 7.14;

Moreover it updates the README with the new compatibility section content.

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion about the place of the compatibility info inside the PHP book.

Comment on lines 1 to 7
[[compatibility]]
== Compatibility

Language clients are forward compatible; meaning that clients support communicating
with greater or equal minor versions of Elasticsearch. Elasticsearch language
clients are only backwards compatible with default distributions and without
guarantees made.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the rest of the Client books, we added the compatibility information to the Installation section as a level-three sub-section:

[discrete]
[[compatibility]]
=== Compatibility

If there is no particular reason to add this info as a separate section, I would suggest moving this content under the Installation section.

@@ -5,6 +5,8 @@ include::{asciidoc-dir}/../../shared/attributes.asciidoc[]

include::overview.asciidoc[]

include::compatibility.asciidoc[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you move the compatibility info under Installation, then this item can be deleted.

Suggested change
include::compatibility.asciidoc[]

Copy link
Contributor Author

@ezimuel ezimuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just moved the compatibility section into installation as suggested.

@ezimuel ezimuel requested a review from szabosteve September 13, 2021 15:22
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ezimuel ezimuel merged commit 2f9a3ed into elastic:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants