-
Notifications
You must be signed in to change notification settings - Fork 981
[DOCS] Added compatibility section in doc + updated release notes #1163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion about the place of the compatibility info inside the PHP book.
docs/compatibility.asciidoc
Outdated
[[compatibility]] | ||
== Compatibility | ||
|
||
Language clients are forward compatible; meaning that clients support communicating | ||
with greater or equal minor versions of Elasticsearch. Elasticsearch language | ||
clients are only backwards compatible with default distributions and without | ||
guarantees made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the rest of the Client books, we added the compatibility information to the Installation
section as a level-three sub-section:
[discrete]
[[compatibility]]
=== Compatibility
If there is no particular reason to add this info as a separate section, I would suggest moving this content under the Installation section.
docs/index.asciidoc
Outdated
@@ -5,6 +5,8 @@ include::{asciidoc-dir}/../../shared/attributes.asciidoc[] | |||
|
|||
include::overview.asciidoc[] | |||
|
|||
include::compatibility.asciidoc[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you move the compatibility info under Installation
, then this item can be deleted.
include::compatibility.asciidoc[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just moved the compatibility
section into installation
as suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR provides the following changes in the documentation:
Moreover it updates the README with the new compatibility section content.