Skip to content

Fix #1176 rename includePortInHostHeader to setIncludePortInHostHeader #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix #1176 rename includePortInHostHeader to setIncludePortInHostHeader #1178

wants to merge 1 commit into from

Conversation

huanes
Copy link

@huanes huanes commented Nov 23, 2021

This PR modifies #997 by renaming the added method and therefore fixes #1176 as the aforementioned method is now accessible via ClientBuilder fromConfig as well.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ezimuel
Copy link
Contributor

ezimuel commented Dec 6, 2021

@huanes thanks for the PR. Unfortunately, we cannot rename includePortInHostHeader in setIncludePortInHostHeader because this will be a BC break. I proposed a different approach in #1181 to support includePortInHostHeader in ClientBuilder::fromConfig.

@ezimuel
Copy link
Contributor

ezimuel commented Dec 6, 2021

Closing in favor or #1181

@ezimuel ezimuel closed this Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huanes @elasticmachine @ezimuel