Skip to content

Conversation

@ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Aug 23, 2022

This PR fixes #1227

@hkulekci
Copy link
Contributor

hkulekci commented Aug 23, 2022

I think we need to change the AbstractEndpoint::__construct method parameter types from Client to ClientInterface.

@ezimuel
Copy link
Contributor Author

ezimuel commented Aug 24, 2022

@hkulekci good catch, thanks! I updated the PR.

@ezimuel ezimuel merged commit eba27a8 into 8.4 Aug 24, 2022
@ezimuel ezimuel deleted the client-interface branch August 24, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants