Skip to content

PHP 8.4 compatibility #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2024
Merged

PHP 8.4 compatibility #1415

merged 2 commits into from
Nov 4, 2024

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Oct 31, 2024 •
edited
Loading

Fixes #1413

@ruudk ruudk requested a review from a team as a code owner October 31, 2024 09:06
@ruudk ruudk mentioned this pull request Oct 31, 2024
Closed
@ruudk
Copy link
Contributor Author

ruudk commented Oct 31, 2024

@ezimuel Could you please approve the workflow?

ezimuel
ezimuel approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@ezimuel ezimuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@ezimuel ezimuel merged commit 7440931 into elastic:main Nov 4, 2024
8 checks passed
@ruudk
Copy link
Contributor Author

ruudk commented Nov 4, 2024

Thanks, can this be tagged ?

@ruudk ruudk mentioned this pull request Nov 11, 2024
Closed
@ruudk ruudk deleted the patch-3 branch November 13, 2024 08:22
@ezimuel
Copy link
Contributor

ezimuel commented Nov 15, 2024

This PR has been released in 8.16.0

@igoooor
Copy link

igoooor commented Jan 27, 2025

any chance to see this one in v7?

@thecaliskan
Copy link

Hi @ezimuel I hope you're well!

If we wait a little longer, PHP 8.5 might just released! 😆

@BernardA
Copy link

BernardA commented Apr 7, 2025

@ruudk I second @igoooor concerning having this fixed in v7, if possible

@ruudk
Copy link
Contributor Author

ruudk commented Apr 7, 2025

Feel free to create a PR to address this. I don't have interest in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezimuel ezimuel ezimuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.4 Deprecations in ClientBuilder
5 participants
@ruudk @ezimuel @igoooor @thecaliskan @BernardA