Drop Monolog dependency from ClientBuilder #674
Conversation
docs/build/renderer.index
Outdated
| C:19:"Sami\Renderer\Index":1041:{a:3:{i:0;a:10:{s:20:"Elasticsearch\Client";s:40:"6ac4061ad03df8cddeaec31a8bfb556fc7a33e71";s:27:"Elasticsearch\ClientBuilder";s:40:"6b9f0fd58072ecaf8820c64a087b5ab03b2213d3";s:37:"Elasticsearch\Namespaces\CatNamespace";s:40:"a9d466909dc08564e9c1516162c3a6bb91dbecbe";s:41:"Elasticsearch\Namespaces\ClusterNamespace";s:40:"0934f56b5dfa7978ab1907b6c8a04b0a293ae274";s:41:"Elasticsearch\Namespaces\IndicesNamespace";s:40:"66391991c19f28764c86e9604e231b9ce004c82e";s:40:"Elasticsearch\Namespaces\IngestNamespace";s:40:"b52adeb7071f16cba79cdcc3dac3fa6e53ed62bd";s:39:"Elasticsearch\Namespaces\NodesNamespace";s:40:"da4e71f9d953d00600920c26fe585b6884e45f94";s:40:"Elasticsearch\Namespaces\RemoteNamespace";s:40:"a503f6ea82452e1ea0275a044aeb527bc946616d";s:42:"Elasticsearch\Namespaces\SnapshotNamespace";s:40:"e28a1807789b0fcca3fd6b9712ed713650cf7ac2";s:39:"Elasticsearch\Namespaces\TasksNamespace";s:40:"2de86d7ab409a629320725f6444c76d2a9313c72";}i:1;a:1:{i:0;s:6:"master";}i:2;a:2:{i:0;s:13:"Elasticsearch";i:1;s:24:"Elasticsearch\Namespaces";}}} |
There was a problem hiding this comment.
(Result of docs rebuilding)
mhujer
force-pushed
the
mh-remove-monolog-dependency
branch
from
140be34
to
737f297
Compare
|
Rebased to resolve conflicts. |
mhujer
force-pushed
the
mh-remove-monolog-dependency
branch
from
737f297
to
923108c
Compare
|
Welp, I suppose it's time to drop the default logger. Still seems a shame as it's a nice user-friendliness feature... but I've also seen it cause problems since people try to use it before installing Monolog. |
|
I think we should add a blurb to the Breaking Changes doc for master, and I think we can only merge this into Master. Ship sailed for 6.x unfortunately (my fault for the delay) since this would outright break code if someone is relying on the method |
mhujer
force-pushed
the
mh-remove-monolog-dependency
branch
2 times, most recently
from
8f9d93c
to
40b60af
Compare
mhujer
force-pushed
the
mh-remove-monolog-dependency
branch
from
40b60af
to
f8ddeca
Compare
|
We definitely can't remove a method in a minor version :-) so this must go to the I've added a note to the |
| @@ -1033,27 +1032,6 @@ $response = $client->deleteTemplate($params); | |||
|
|
|||
|
|
|||
|
|
|||
| [[Elasticsearch_ClientputTemplate_putTemplate]] | |||
There was a problem hiding this comment.
I've rebuilt the docs, therefore this unrelated change.
I've removed the helper method and updated the docs as noted in #296.
Should I include the change in the
BREAKING_CHANGES.mddocument? (for which version?)This change is necessary for analyzing
src/with PHPStan. Otherwise it is trying to load\Monolog\Logger\Loggerwhich is not listed as a dependency incomposer.jsonand therefore PHPStan fails in a spectacular way(This closes #296, and closes #579)