Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Drop Python 3.4 support #70

Closed
vEpiphyte opened this issue Oct 19, 2019 · 3 comments
Closed

Drop Python 3.4 support #70

vEpiphyte opened this issue Oct 19, 2019 · 3 comments

Comments

@vEpiphyte
Copy link

Can we drop Python 3.4 support from this library? It has reached end-of-life and is no longer maintained by the Python Software Foundation. See https://www.python.org/dev/peps/pep-0429/#release-schedule for the 3.4 EOL notice.

Dropping 3.4 would allow us to migrate everything into a modern async def syntax and use async generators. Async generators would allows this library to support scroll/scan API as well as Bulk api's easier. I've got a fork which implements most of those helpers as async versions already; and it was trivial to do with async generator support.

@honzakral @fxdgear

@vEpiphyte
Copy link
Author

Example bulk helpers and scan support can be seen here
master...vertexproject:feature_bulk_helpers

@vEpiphyte
Copy link
Author

vEpiphyte commented Oct 22, 2019

Upon reading #5 it would probably also be best for to drop 3.5 as well since then we'll get the proper async generator support (I had previously misread the Python release notes when I put together the original post).

@sethmlarson
Copy link
Contributor

Since there will be no further major versions of this package we will not be dropping Python support. Closing this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants