This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Add trace_configs param to connection #63
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow support for AWS X-Ray integration, via trace_config passed to aiohttp.ClientSession See https://docs.aws.amazon.com/xray/latest/devguide/xray-sdk-python-httpclients.html for more details
Add trace_config param to connection
|
Just signed the Contributor License Agreement. Do I also need to open an issue and link this PR to it? |
|
@fxdgear I also need this - any possibility of getting this merged? |
|
This repository won't be adding additional features. See #81 for more information. If this support is needed please make this PR upstream in the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows trace_configs to be passed through, which is needed for AWS XRay support.
More info here: https://docs.aws.amazon.com/xray/latest/devguide/xray-sdk-python-httpclients.html