-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Missing surrogatepass in urllib3 handler #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…onse with surrogatepass error handler.
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Coworker has confirmed for me that this has resolved the issue he was seeing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, can we also add this to the RequestsHttpConnection
? Can change response.text
to response.content.decode("utf-8", "surrogatepass")
jenkins test this please |
@sethmlarson I'd be happy to add it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A coworker of mine encountered an issue when retrieving a document, when using the scrollapis, causing a decoding issue in the urllib3 connection class.
This is similar to #612 and #629 .