-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Deprecate the 'http_auth' parameter #1776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sim0nx Hello! Thanks for commenting here, the current plan is to only support Basic, Bearer, and API Keys for authentication. What is your use-case for custom HTTP authentication specifically for Requests? |
My long time use case is supporting kerberos/gsaapi authentication. I would thus highly appreciate it if you could leave support in there for custom auth handlers :-) |
Gotcha! I'll leave the deprecation for |
Great! Thank you! 👍 |
Captured this use-case here: #1778 Sorry to have removed it at all, I didn't actually know there was a use-case for it beyond Basic as none were documented 😅. TIL! |
Lucky me I by coincidence browsed this project because of various deprecation warnings and saw your commit :-D Thanks again, much appreciated! |
@sim0nx Are your custom handlers available anywhere public? If so might be useful to make some sort of template available. |
Sure, I currently use requests-gssapi (https://pypi.org/project/requests-gssapi/). import requests
from requests_gssapi import HTTPSPNEGOAuth
conn = elasticsearch.Elasticsearch(...,
connection_class=elasticsearch.RequestsHttpConnection,
http_auth=HTTPSPNEGOAuth(),
...
) |
This parameter is deprecated in favor of
basic_auth
.