Build dists as part of CI #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
miguelgrinberg
approved these changes
Nov 13, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
(cherry picked from commit 6ba6e38)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
(cherry picked from commit 6ba6e38)
pquentin
commented
Nov 13, 2024
| from ..._version import __versionstr__ | ||
| from ...compat import to_bytes, to_str, warn_stacklevel | ||
| from ...exceptions import GeneralAvailabilityWarning |
There was a problem hiding this comment.
This part is needed for the elasticsearch8 package. All imports are relative for this reason.
| @@ -102,7 +102,7 @@ def helpers_span(self, span_name: str) -> Generator[OpenTelemetrySpan, None, Non | |||
|
|
|||
| @contextlib.contextmanager | |||
| def use_span(self, span: OpenTelemetrySpan) -> Generator[None, None, None]: | |||
| if not self.enabled or self.tracer is None: | |||
| if not self.enabled or self.tracer is None or span.otel_span is None: | |||
There was a problem hiding this comment.
This change is needed for mypy: trace.use_span below expects a Span, but span.otel_span is typed as Span | None (to handle the case where OpenTelemetry is not available).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build-dists.py step often fails during publishing, let's add it to CI.