-
Notifications
You must be signed in to change notification settings - Fork 1.2k
autogenerate field classes from schema #2780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autogenerate field classes from schema #2780
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
a1ede9b
to
4539281
Compare
4539281
to
cd22164
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
* autogenerate field classes from schema * generated code * special case the dynamic field to also be a bool (cherry picked from commit 6e23635)
* autogenerate field classes from schema * generated code * special case the dynamic field to also be a bool (cherry picked from commit 6e23635)
This change adds autogeneration of field classes in the DSL module from the Elasticsearch specification, so that the class constructors have explicit arguments and docstrings.