Skip to content

Use HTTP POST for elasticsearch.scroll(). #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gmazzola
Copy link

Addresses Issue #971

This pull request POSTs a JSON payload to the Elasticsearch scroll endpoint. We generate the POST body sanely by prioritizing the body argument first, and if it is absent, we generate a valid body using the scroll_id and scroll arguments.

This PR does not change the method signature. I tested it against an Elasticsearch 6.2.4 cluster and also via the existing unittests. I have also signed the contributor agreement. :)

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ghost
Copy link

ghost commented Jun 25, 2019

Hi @gmazzola, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@gmazzola gmazzola closed this Jun 25, 2019
@gmazzola
Copy link
Author

Will re-open this pull request using my personal git credentials. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants