Drop runtime dependency on base64 #2295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2282 added
base64
as a runtime dependency. It's easy enough to replace, thebase64
is for the most part a wrapper around thepack
/unpack
methods.Also see:
base64
bblimke/webmock#1046base64
gem from runtime dependency rubocop/rubocop#12313I have made it a dev dependency since test files use it in a bunch of places and replacing all that doesn't make the code much better.