-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc java fixes 220617 #1773
Misc java fixes 220617 #1773
Conversation
Should we add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If output/schema/schema-no-generics.json
is removed then we should be good to go.
Good catch with |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-1773-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 81791d0a76ad60b997a42e782a25d39a7b5b2363
# Push it to GitHub
git push --set-upstream origin backport-1773-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17 Then, create a pull request where the |
* Fix MultiTermsRequest - elastic/elasticsearch-java#160 * TypeFieldMappings is a multi-key dictionary - elastic/elasticsearch-java#166 * Fix TranslateSqlResponse - elastic/elasticsearch-java#167 * Token filter properties are generally optional - elastic/elasticsearch-java#199 * Fix typo in IndexSettings.mapping and allow extended settings - elastic/elasticsearch-java#295 * ShardRecovery.stop_time_in_millis is optional - elastic/elasticsearch-java#202
* Fix MultiTermsRequest - elastic/elasticsearch-java#160 * TypeFieldMappings is a multi-key dictionary - elastic/elasticsearch-java#166 * Fix TranslateSqlResponse - elastic/elasticsearch-java#167 * Token filter properties are generally optional - elastic/elasticsearch-java#199 * Fix typo in IndexSettings.mapping and allow extended settings - elastic/elasticsearch-java#295 * ShardRecovery.stop_time_in_millis is optional - elastic/elasticsearch-java#202
Fixes some spec issues found in the Java client:
Missing fields in MultiTermsAggregation.
Found in Missing fields in
MultiTermsAggregation
elasticsearch-java#319TypeFieldMappings is a multi-key dictionary.
Found in getFieldMapping error when several fields elasticsearch-java#166
Missing/wrong fields in ExplainSqlRequest.
Found in TranslateResponse is missing "query" elasticsearch-java#167
Misc fixes on token filters.
Found in Could not get list of indices due to co.elastic.clients.util.MissingRequiredPropertyException: Missing required property 'LimitTokenCountTokenFilter.consumeAllTokens' elasticsearch-java#199
Fix typo in IndexSettings.mapping and allow extended settings.
Found in Impossible to set index.mapping.nested_objects_limit and index.requests.cache.enable elasticsearch-java#295
ShardRecovery.stop_time_in_millis is optional.
Found in [es/indices.recovery] Missing required property 'ShardRecovery.stopTimeInMillis' elasticsearch-java#202