Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow single fields in fields and _source parameters #2317

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

pquentin
Copy link
Member

@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
msearch 🟢 17/17 16/16
search 🔴 1519/1538 1517/1520

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin requested a review from a team November 2, 2023 07:53
Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pquentin pquentin merged commit 9f40be8 into main Nov 6, 2023
8 checks passed
@pquentin pquentin deleted the single-fields-source branch November 6, 2023 07:41
Copy link
Contributor

github-actions bot commented Nov 6, 2023

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2317-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9f40be8b64f80a8602c362aae25ff27be71e1b9a
# Push it to GitHub
git push --set-upstream origin backport-2317-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-2317-to-7.17.

Copy link
Contributor

github-actions bot commented Nov 6, 2023

The backport to 8.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.10 8.10
# Navigate to the new working tree
cd .worktrees/backport-8.10
# Create a new branch
git switch --create backport-2317-to-8.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9f40be8b64f80a8602c362aae25ff27be71e1b9a
# Push it to GitHub
git push --set-upstream origin backport-2317-to-8.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.10

Then, create a pull request where the base branch is 8.10 and the compare/head branch is backport-2317-to-8.10.

Copy link
Contributor

github-actions bot commented Nov 6, 2023

The backport to 8.11 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.11 8.11
# Navigate to the new working tree
cd .worktrees/backport-8.11
# Create a new branch
git switch --create backport-2317-to-8.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9f40be8b64f80a8602c362aae25ff27be71e1b9a
# Push it to GitHub
git push --set-upstream origin backport-2317-to-8.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.11

Then, create a pull request where the base branch is 8.11 and the compare/head branch is backport-2317-to-8.11.

pquentin added a commit that referenced this pull request Nov 6, 2023
pquentin added a commit that referenced this pull request Nov 6, 2023
pquentin added a commit that referenced this pull request Nov 6, 2023
@pquentin
Copy link
Member Author

pquentin commented Nov 7, 2023

Since this is a breaking change for typed clients and too late for 8.11, I'm reverting the backports (but not the change in main):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants