-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow single fields in fields and _source parameters #2317
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2317-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9f40be8b64f80a8602c362aae25ff27be71e1b9a
# Push it to GitHub
git push --set-upstream origin backport-2317-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.10 8.10
# Navigate to the new working tree
cd .worktrees/backport-8.10
# Create a new branch
git switch --create backport-2317-to-8.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9f40be8b64f80a8602c362aae25ff27be71e1b9a
# Push it to GitHub
git push --set-upstream origin backport-2317-to-8.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.10 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.11 8.11
# Navigate to the new working tree
cd .worktrees/backport-8.11
# Create a new branch
git switch --create backport-2317-to-8.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9f40be8b64f80a8602c362aae25ff27be71e1b9a
# Push it to GitHub
git push --set-upstream origin backport-2317-to-8.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.11 Then, create a pull request where the |
(cherry picked from commit 9f40be8)
(cherry picked from commit 9f40be8)
(cherry picked from commit 9f40be8)
Since this is a breaking change for typed clients and too late for 8.11, I'm reverting the backports (but not the change in main): |
This was initially reported in elastic/elasticsearch-py#2347
The
_source
body field used to work but was broken in https://github.com/elastic/elasticsearch-specification/pull/1027/files#diff-4114e335296798822015a064d77c5c6d14c797a89c76a0d08b63dcf5d4028651.Based on https://www.elastic.co/guide/en/elasticsearch/reference/current/search-fields.html, I fixed
_source
,fields
anddocvalue_fields
.