Skip to content

[DOCS]: Clarify GET / response on Serverless #4981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

charlotte-hoblik
Copy link
Contributor

This PR:

  • clarifies the response when a user runs GET /
  • updates the existing example response
  • adds a new example specific to serverless deployments.

On Serverless, this endpoint will always return 8.11.0 as the version number and it is expected. Serverless offers automatic upgrades. Version is no longer something the user manages.

Based on: elastic/docs-content#1960

Copy link
Contributor

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@charlotte-hoblik
Copy link
Contributor Author

@leemthompo One question: I used the ::: syntax in my changes to highlight notes (screenshot attached). It renders really nicely in the built docs, but I haven’t seen anyone else use it, so I’m not sure if it’s officially supported or just working by coincidence.

Could you let me know if it’s safe to use? I’d prefer to avoid relying on something that might break later.
Screenshot 2025-07-21 at 10 28 27
Screenshot 2025-07-21 at 10 28 36

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @charlotte-hoblik! Just suggested a rewording for clarity. On the ::: syntax, I have no idea TBH, I think @flobernd probably knows about this. 😄

I'll let @ppf and @rjernst weigh in on this too

charlotte-hoblik and others added 3 commits July 21, 2025 16:06
@leemthompo
Copy link
Contributor

@charlotte-hoblik you'll need to run your make generate commands again to make sure the output files are also updated

Would be nice to have screenshots of the examples too for reviewers :)

@@ -0,0 +1,19 @@
# summary: ''
description: A successful response from `GET /` on Serverless.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also add as much information to the description field as you like to provide context

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ I see that the most important details are in comment blocks in code today. Let's move that into the description field so that it will actually show up in the API doc details?

  /**
   * The Elasticsearch version number.
   *
   * ::: IMPORTANT: For Serverless deployments, this static value is always `8.11.0` and is used solely for backward compatibility with legacy clients.
   *  Serverless environments are versionless and automatically upgraded, so this value can be safely ignored.
   */

Also, in the description field, I will suggest in addition to noting "safely ignored", it will be helpful to explicitly call out that Serverless are automatically upgraded to the most current version. Thx!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Typescript comments actually are used to generate the OpenAPI documents! But the example yaml files can also have extended descriptions

This is the Elasticsearch api docs workflow schematic:

api-docs-generation-pipeline

Copy link
Contributor

@leemthompo leemthompo Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be helpful to explicitly call out that Serverless are automatically upgraded to the most current version.

@ppf I wonder if this wording might confuse people into thinking they're running the current/latest stack version?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, we can leave it out. I think automatically upgraded already suggests it's upgrading to the latest version that is appropriate for Serverless :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-07-22 at 15 36 34 Screenshot 2025-07-22 at 15 37 35

Thanks for the feedback @leemthompo @ppf2 I’ve added the same clarification to the new Serverless example as well.
Let me know if anything else needs tweaking.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the user clicks on the version OBJECT item:

image

Is it going to show something like the following?

  /**
   * The Elasticsearch version number.
   *
   * ::: IMPORTANT: For Serverless deployments, this static value is always `8.11.0` and is used solely for backward compatibility with legacy clients.
   *  Serverless environments are versionless and automatically upgraded, so this value can be safely ignored.
   */

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants