Skip to content

Conversation

@markjhoy
Copy link
Contributor

Adds the new diversify retriever type to the specification for 9.3 based on work done here: elastic/elasticsearch#135880

@markjhoy markjhoy requested a review from a team November 26, 2025 15:41
@markjhoy markjhoy added specification skip-backport This pull request should not be backported labels Nov 26, 2025
@github-actions
Copy link
Contributor

Following you can find the validation changes against the target branch for the API.

API Status Request Response
search 🔴 2797/2825 → 2805/2825 2825/2825

You can validate this API yourself by using the make validate target.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Good to see that this fixes a bunch of YAML tests.

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rank_window_size?: integer
/** The query vector used for diversification. */
query_vector?: QueryVector
/** Controls the trade-off between relevance and diversity for MMR. A value of 0.0 focuses solely on diversity, while a value of 1.0 focuses solely on relevance. Required for MMR */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice comment/clarification ❤️

@markjhoy markjhoy merged commit d1afeb9 into main Dec 1, 2025
14 checks passed
@markjhoy markjhoy deleted the markjhoy/dsl-diversify-mmr-retriever branch December 1, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-backport This pull request should not be backported specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants