Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config GUI: on connect editing, Connect button works as Cancel #27

Closed
bpintea opened this issue Oct 9, 2018 · 4 comments
Closed

Config GUI: on connect editing, Connect button works as Cancel #27

bpintea opened this issue Oct 9, 2018 · 4 comments
Labels

Comments

@bpintea
Copy link
Collaborator

bpintea commented Oct 9, 2018

When opening the GUI on connect (i.e. not while editing existing / adding a new DSN), pressing on the Connect button is propagated to the driver as a Cancel action.

@bpintea bpintea added the >bug label Oct 9, 2018
@codebrain
Copy link
Contributor

Fixed in bpintea@1bd7bd7

@bpintea bpintea closed this as completed Oct 11, 2018
@bpintea bpintea reopened this Oct 11, 2018
@bpintea
Copy link
Collaborator Author

bpintea commented Oct 11, 2018

Not positive if this is related to the fix, but in this case now - on connecting - pressing the Cancel button doesn't work: the driver is returned the length of the DSN string instead of 0, which signals the driver that the user pressed actually the Connect button.

@codebrain
Copy link
Contributor

Apologies - error occurred between keyboard and chair. Now fixed!

@bpintea
Copy link
Collaborator Author

bpintea commented Oct 14, 2018

Thank you, works now as expected.

@bpintea bpintea closed this as completed Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants