Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config GUI: activate Save and Test Connection buttons only if input is present #29

Closed
bpintea opened this issue Oct 9, 2018 · 2 comments

Comments

@bpintea
Copy link
Collaborator

bpintea commented Oct 9, 2018

In case of editing or adding a DSN, the Save and Test Connection should only be activated if there is valid input, as follows:

  • the Save button requires a DSN Name and Hostname filled in;
  • the Test Connection button requires at least the Hostname field filled in. The delux feature here would be do have validation on the field (hostname or IPv4/6), but this only if there is already some ready to use framework functionality (regexps or building a parser here might be inadvisable).
@codebrain
Copy link
Contributor

We can probably use the Uri parser in .NET to perform some validations for us (agree that writing our own parser is not a good idea!)

https://docs.microsoft.com/en-us/dotnet/api/system.uri.-ctor?view=netframework-4.7.2

@bpintea
Copy link
Collaborator Author

bpintea commented Oct 11, 2018

Thank you!

@bpintea bpintea closed this as completed Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants