BETA Todos

[codebrain]

Branch from master, backport changes to 6.x

• Merge build processes for driver and MSI into a single build command. This is to simplify the build script process and remove the need to perform cd <dir> commands in the release manager. - @codebrain / @bpintea - Build: integrate installer's build.bat with driver's #69
• Unit / integration tests for editor dialog after moving to an MVVM or MVC architecture.- @codebrain
• Review AssemblyInfo version patching and ensure consistency across all .NET projects. - @codebrain - https://github.com/bpintea/elasticsearch-sql-odbc/tree/feature/integrate_installer_build
• Consolidate .gitignore files across the repo. - @codebrain - Merge gitignore files across projects #71
• Ensure copyright year is present in AssemblyInfo files. - @codebrain to find out if needed (none of the other DLLs use year). - https://github.com/bpintea/elasticsearch-sql-odbc/tree/feature/integrate_installer_build
• Align the editor to either all tabs or all space. (The driver uses tabs, but we can delineate between the two). @codebrain to implement editor rules as defined by Microsoft team. - Cleanup whitespace, add .editorconfig as standardised by Microsoft te… #67
• Chain (tick-box-dependent) the ODBC Data Source Administrator app to the installer - include getting started screen (as per Elasticsearch MSI) @codebrain - Launch ODBC Administrator control panel on exit. #65
• Considerations the VS redistributable @codebrain / @bpintea
• Documentation: installer @codebrain; editor @bpintea
• Blog post prep @bpintea
• DSN editor tooltips? (optional) - Cleanup whitespace, add .editorconfig as standardised by Microsoft te… #67
• 32-bit build (optional):
• for the driver @bpintea - Split architecture-specific builds to separate directories #76
• for the installer @codebrain - Installer: 32 bit support #70, Integrate driver's and installer's build scripts #74, Installer cleanup #79
• rename DSN binding DLL to include 32 for 32-bit builds; @bpintea - Better 32bit support #63
• integrate x86 build into RM: https://github.com/elastic/release-manager/pull/506
• Validations on DSN editor for:
• Name field - limit to registry key characters - Add validations into DSN editor form #59
• Ensure all field entries are no longer than 512 characters - Add validations into DSN editor form #59
• Launch ODBC editor on close (with checkbox) Installer cleanup #79

[sophiec20]

@bpintea Are we sure the 32-bit version is necessary? It's a significant overhead on deployment, build and test. Are we sure we have the user demand to warrant this?

[bpintea]

@sophiec20, I've marked it "optional" (as it should have been probably), as I think at this stage we're evaluating it.
32 bit building of the driver only is low hanging (and pretty much done). Integrating into the RM, extended testing and whether or not to use a 32 bit installer, yes, all that needs discussion.

On the longer run it shouldn't be an overly complicated task and IMO there are enough arguments for it.
Weather this is the moment -- debatable, true.

(FWIW, this had always been on the list, but it became a topic now given the first reported user experience with Office. Microsoft has been recommended the 32 bit version of Office for a while - not sure if this still is the case with the late releases - and it might still be the default with some OEM installations. Depending on the target user profile - corporate vs. private - installing an x64 Office build might be or not an issue.)

We will discuss openly the feasibility on Monday at @pcsanwald proposal, part of the SQL team sync, hopefully being better informed by then. I believe you'd be welcome to join it.

[sophiec20]

@bpintea Thanks for the clarification.

MSFT still release as 32-bit, but are not overly positive about actually using it. https://support.office.com/en-us/article/choose-between-the-64-bit-or-32-bit-version-of-office-2dee7807-8f95-4d0c-b5fe-6c6f49b8d261

The recent activity raised concerns in my mind around timing - would be very keen to see the build processes merged for what we have now, before introducing additional complexity.

[codebrain]

Couple of questions raised on this weeks MS team sync:

• Where are issues with the driver / installer being raised? Do we have a feedback mechanism from customers?
• When is this repository being made public?
• Downloads page: ODBC driver is listed as client (should it be called driver instead?)
• Documentation link from https://www.elastic.co/downloads/odbc-client page

[bpintea]

Where are issues with the driver / installer being raised? Do we have a feedback mechanism from customers?

There's currently nothing dedicated; the forums and GitHub would be the first repos for these.

When is this repository being made public?

I've asked for a final confirmation; if no objection will be raised, I'll open it by the end of the week.

ODBC driver is listed as client (should it be called driver instead?)

Yes, it probably should. I think the server devs see it as a client, but for the real clients, it's a driver. I'll raise it.

Documentation link from https://www.elastic.co/downloads/odbc-client page

https://github.com/elastic/website-www.elastic.co/issues/3279

[bpintea]

I've asked for a final confirmation; if no objection will be raised, I'll open it by the end of the week.

Still pending two PRs which I'd rather have merged before opening. They both should be addressed, pending on reviewers, currently. Will update.

The above mentioned PRs have been merged. I've opened another one (#74) that I'd like merged into the repository before opening, since this PR has been implemented in a private fork, that would need to be deleted and recreated off the public repo. Delaying the opening is the most convenient option.

[bpintea]

Repo is now public.

[codebrain]

@bpintea - Is it worth closing this ticket down and breaking out the remaining TODOS into their own tickets?

[bpintea]

Yes, makes sense.
I'll leave to you "Unit / integration tests for editor dialog after moving to an MVVM or MVC architecture".
Let's re-sync on "Considerations the VS redistributable".
I've started chatting to Shane on the blog post and will follow up.